Backport of Correct Issue browser-actions/setup-chrome into release/1.13.x #19904
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
requested a review
from a team
as a code owner
hc-github-team-secure-vault-core
force-pushed
the
backport/marcboudreau/test-setup-chrome/initially-hopeful-piglet
branch
from
8295328
to
f8714e1
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/marcboudreau/test-setup-chrome/initially-hopeful-piglet
branch
from
3042d05
to
689f9c6
Compare
marcboudreau
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #19876 to be assessed for backporting due to the inclusion of the label backport/1.13.x.
The below text is copied from the body of the original PR.
This PR fixes the issue where the browser-actions/setup-chrome action would fail in the test-ui workflow job: https://github.com/hashicorp/vault/actions/runs/4575976373/jobs/8079513066
The problem was that an incorrect commit hash was being used. The proposed commit hash is the correct one and it was verified by temporarily removing the if condition on the test-ui job. This caused the job to execute in this branch: https://github.com/hashicorp/vault/actions/runs/4575747084/jobs/8078976210
Overview of commits